Skip to content

Commit

Permalink
feat: Apache Superset UI Icons (#1100)
Browse files Browse the repository at this point in the history
adds Apache Superset icons to frontend
  • Loading branch information
mgorsk1 authored May 16, 2021
1 parent db33e5b commit c441ed7
Show file tree
Hide file tree
Showing 8 changed files with 22 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
/amundsen-kube-helm/ @feng-tao @jornh @javamonkey79

common/*.py @feng-tao @jinhyukchang @allisonsuarez @verdan @bolkedebruin @mgorsk1 @dorianj
databuilder/*.py @feng-tao @jinhyukchang @allisonsuarez @dikshathakur3119 @dorianj @verdan
databuilder/*.py @feng-tao @jinhyukchang @allisonsuarez @dikshathakur3119 @dorianj @verdan @mgorsk1
frontend/amundsen_application/static/ @Golodhros @ttannis @allisonsuarez @dikshathakur3119 @feng-tao @dorianj
frontend/*.py @ttannis @feng-tao @dikshathakur3119 @allisonsuarez @dorianj @verdan
metadata/*.py @feng-tao @jinhyukchang @allisonsuarez @dikshathakur3119 @verdan @bolkedebruin @mgorsk1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class ApacheSupersetBaseExtractor(Extractor):
APACHE_SUPERSET_PORT: '8088',
APACHE_SUPERSET_PAGE_SIZE: 20,
APACHE_SUPERSET_EXTRACT_PUBLISHED_ONLY: False,
PRODUCT: 'apache_superset',
PRODUCT: 'superset',
DASHBOARD_GROUP_DESCRIPTION: '',
DRIVER_TO_DATABASE_MAPPING: DEFAULT_DRIVER_TO_DATABASE_MAPPING,
DATABASE_TO_CLUSTER_MAPPING: {}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def test_extractor(self) -> None:
self.assertIsInstance(record, DashboardQuery)
self.assertEqual(record._query_name, 'default')
self.assertEqual(record._query_id, '-1')
self.assertEqual(record._product, 'apache_superset')
self.assertEqual(record._product, 'superset')
self.assertEqual(record._cluster, 'gold')

record = extractor.extract()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def test_extractor(self) -> None:
self.assertEqual(record.dashboard_name, 'dashboard name')
self.assertEqual(record.description, '')
self.assertEqual(record.cluster, 'gold')
self.assertEqual(record.product, 'apache_superset')
self.assertEqual(record.product, 'superset')
self.assertEqual(record.dashboard_group_id, '1')
self.assertEqual(record.dashboard_id, '2')
self.assertEqual(record.dashboard_group_description, 'dashboard group description')
Expand All @@ -74,5 +74,5 @@ def test_extractor(self) -> None:
self.assertEqual(record._dashboard_group_id, '1')
self.assertEqual(record._dashboard_id, '2')
self.assertEqual(record._last_modified_timestamp, 1620981665)
self.assertEqual(record._product, 'apache_superset')
self.assertEqual(record._product, 'superset')
self.assertEqual(record._cluster, 'gold')
1 change: 1 addition & 0 deletions frontend/amundsen_application/static/css/_icons.scss
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ $dashboards: (
mode: '../images/icons/logo-mode.svg',
redash: '../images/icons/logo-redash.svg',
tableau: '../images/icons/logo-tableau.svg',
superset: '../images/icons/logo-superset.svg',
);

// Map of User names and icon paths
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@ const configDefault: AppConfig = {
displayName: 'Tableau',
iconClass: 'icon-tableau',
},
superset: {
displayName: 'Superset',
iconClass: 'icon-superset',
},
},
filterCategories: [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ export enum IconType {
POSTGRES = 'icon-postgres',
REDSHIFT = 'icon-redshift',
SNOWFLAKE = 'icon-snowflake',
SUPERSET = 'icon-superset',
}

// Icon sizes
Expand Down

0 comments on commit c441ed7

Please sign in to comment.