🐛 Fix amp-twitter component resizing issue #37740
Conversation
|
I'm going to look at making an e2e test for this. I'm actually not clear how feasible that it is to test this interaction, but I think it'll be worth a shot to avoid regressions. |
|
Well after some quick-ish investigation it appears that the bento-twitter web-component is broken and never had any e2e tests build for it. But I don't think this is a blocker for this PR, but it in an obvious over sight that we'll need to fix later. |
|
Thanks for the fix @deepaklalwani97. I'm approving this, but also adding @alanorozco to approve. |
|
|
||
| if (iframeRef.current.node.getRootNode().host) { | ||
| // Remove the position style from embed after the resize is complete. | ||
| resetStyles(iframeRef.current.node.getRootNode().host, [ |
There was a problem hiding this comment.
Can we use a classname with JSS instead of using setStyles/resetStyles?
There was a problem hiding this comment.
Thanks, @alanorozco I have replaced the setStyles/resetStyles with JSS classes
Head branch was pushed to by a user without write access
|
Hey, @dethstrobe I have fixed some merge conflicts on this PR which seems to have disabled the auto-merge. Please let me know if I can help unblock this PR in any way. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Fixes #37117
This PR fixes the Twitter embed resizing issue using the workaround mentioned by @alanorozco in #37117 (comment). As the resizing of the Twitter embed happens only when it comes into viewport in most cases the embed gets loaded in the unexpanded state this PR uses a workaround to resize the embed when the component gets built.