♻️ Remove attemptChangeHeight method since it has AMP specific overflow feature
#35777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmanek
changed the title
attemptChangeHeight since it has AMP specific overflow featureattemptChangeHeight method since it has AMP specific overflow feature
jridgewell
approved these changes
Aug 23, 2021
caroqliu
requested changes
Aug 24, 2021
| // It's okay to disable this lint rule since we check that the restricted | ||
| // method exists. | ||
| // eslint-disable-next-line local/restrict-this-access | ||
| if (this.getOverflowElement && !this.getOverflowElement()) { |
There was a problem hiding this comment.
It checks if this.getOverFlowElement exists before calling precisely to guard against non-AMP cases: #35027 (comment)
If removing is preferred we should re-add into the AMP layers of affected components (amp-twitter, amp-facebook, amp-instagram) and update the documentation for future components.
There was a problem hiding this comment.
@caroqliu thanks for the context on why this was added. Based on this comment it seems like we should not include any AMP specific code in preact base element. I'm ok either way and leave it up to you and @jridgewell to decide 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attemptChangeHeightlooks for overflow element, which is AMP specific. Removing this method so it calls the parent's i.e. BaseElement'sattemptChangeHeightmethod.Fixes #35760