Perform PR build test (#6788)

* Change test * Update .github/workflows/lint.yaml Co-authored-by: Daniel Rozenberg <[email protected]> * Fix all --------- Co-authored-by: Daniel Rozenberg <[email protected]>
ampproject · Apr 4, 2024 · efb03d9 · efb03d9
1 parent e28233f
commit efb03d9
Show file tree

Hide file tree

Showing 8 changed files with 58 additions and 74 deletions.
diff --git a/.github/workflows/lint-yaml.yaml b/.github/workflows/lint-yaml.yaml
diff --git a/.github/workflows/lint-js.yaml → .github/workflows/lint.yaml b/.github/workflows/lint-js.yaml → .github/workflows/lint.yaml
@@ -1,11 +1,13 @@
 ---
-name: 'Lint: JavaScript'
+name: 'Lint: all'
 
 on:
   workflow_dispatch:
   push:
-    paths:
-      - '**/*.js'
+    branches:
+      - main
+  pull_request:
+
 jobs:
   test:
     runs-on: ubuntu-latest
@@ -22,6 +24,8 @@ jobs:
       - name: Installing Node.js packages
         run: npm ci
 
+      - name: Linting YAML files
+        run: gulp lintYaml
+
       - name: Linting JavaScript files
-        run: |
-          gulp lintNode
+        run: gulp lintNode
diff --git a/.github/workflows/test-default.yaml b/.github/workflows/test-default.yaml
diff --git a/.github/workflows/test-platform.yaml b/.github/workflows/test-platform.yaml
@@ -4,9 +4,9 @@ name: 'Test: Platform'
 on:
   workflow_dispatch:
   push:
-    paths:
-      - 'package.json'
-      - 'platform/lib/**'
+    branches:
+      - main
+  pull_request:
 
 jobs:
   test:

diff --git a/.github/workflows/test-playground.yaml b/.github/workflows/test-playground.yaml
@@ -4,9 +4,9 @@ name: 'Test: Playground'
 on:
   workflow_dispatch:
   push:
-    paths:
-      - 'package.json'
-      - 'playground/**'
+    branches:
+      - main
+  pull_request:
 
 jobs:
   test:

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -38,7 +38,11 @@
 		"_test:pixi:e2e": "APP_ENV=local jest --forceExit -c e2e.jest.config.js",
 		"test:grow-extensions": "cd pages/extensions && if which grow; then python3 -m unittest discover -p \"*_test.py\"; else echo grow not installed with pip. skip tests; fi"
 	},
-	"keywords": ["amphtml", "framework", "documentation"],
+	"keywords": [
+		"amphtml",
+		"framework",
+		"documentation"
+	],
 	"author": "The AMP HTML Authors",
 	"license": "Apache-2.0",
 	"signale": {
@@ -49,7 +53,10 @@
 		"@boilerplate": "boilerplate",
 		"@lib": "platform/lib"
 	},
-	"browserslist": ["last 2 versions", "not dead"],
+	"browserslist": [
+		"last 2 versions",
+		"not dead"
+	],
 	"dependencies": {
 		"@ampproject/toolbox-cache-list": "2.9.0",
 		"@ampproject/toolbox-cors": "2.9.0",
@@ -115,7 +122,7 @@
 		"@rollup/plugin-node-resolve": "15.2.3",
 		"@rollup/plugin-replace": "5.0.5",
 		"absolutify": "0.1.0",
-		"amphtml-validator": "1.0.35",
+		"amphtml-validator": "1.0.38",
 		"ansi-colors": "4.1.3",
 		"archiver": "6.0.1",
 		"babel-loader": "9.1.3",

diff --git a/playground/src/validator/validator.js b/playground/src/validator/validator.js
@@ -17,7 +17,7 @@ import events from '../events/events.js';
 import lazyLoad from '../lazy-load/base.js';
 import {EVENT_SET_RUNTIME} from '../runtime/runtimes.js';
 
-const DEFAULT_VALIDATOR_URL = 'https://ampjs.org/v0/validator_wasm.js';
+const DEFAULT_VALIDATOR_URL = 'https://cdn.ampproject.org/v0/validator_wasm.js';
 
 export const NO_ERRORS = {
   errors: [],