Use customizable width/height args on AMP_Twitter_Embed_Handler rather than literals/defaults
#6510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r than literals/defaults
2 tasks
|
Plugin builds for 8b14b85 are ready 🛎️!
|
pierlon
approved these changes
Aug 4, 2021
westonruter
added
the
Changelogged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up on #6504, fixing a flaw identified by @pierlon in https://github.com/ampproject/amp-wp/pull/6504/files#r681340739.
Instead of using
autoas thewidth, it should have been using$this->args['width]which by default isautobut can be customized.Similarly, instead of using
DEFAULT_HEIGHTas theheight, it should be using$this->args['height']which is customizable.