Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve seek time and other parameters to
amp-youtube
from YouTube embeds #6423Preserve seek time and other parameters to
amp-youtube
from YouTube embeds #6423Changes from 1 commit
2b00609
d5f56f7
080ded2
a4e3290
2e47705
55fff1f
e5fba98
92ab4be
e9ad832
a5d73e0
eceb487
8804f83
220af89
cae32c0
12a722c
520be01
8e484f0
6808668
f60fd46
c35ecd9
547f237
32e9b2d
2d1785a
3ecad1e
74dfcb8
7f21703
2c3ed4d
d519220
0524ae5
b9827d7
fa6ee15
f93b9a1
9d51ef4
9d8e977
8200f3f
edbcc6f
32f358a
1907df3
aac0e40
d983fa4
9eefef9
46bc356
da36d2d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized the AMP component can also [accept a YouTube channel id](Youtube channel id), so we need to provide support for that as well. So if there is no video ID, then check for a live channel ID.
From the docs:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pierlon I have added support for live streaming channels for iframe added as custom HTML markup.
However, WordPress by default does not provide support for embedding YouTube URLs (It will just render as text)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If WordPress never supported it I think it's safe to say we don't have to either.
I tried this but it parsed an incorrect video ID. Eg:
Gives:
Instead, the
data-videoid
attribute should not have been set, nor thedata-param-channel
attribute. Perhaps we could add a condition to say if the parsed video ID islive_stream
then it's invalid and bail.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have addressed this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget the placeholder element: