#53 - cancel query before close connection (#54)

amphp · Jan 6, 2023 · 8e45076 · 8e45076
1 parent c3d2490
commit 8e45076
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/PgSqlHandle.php b/src/PgSqlHandle.php
@@ -195,6 +195,7 @@ private function fetchTypes(string $id): Promise
     public function close(): void
     {
         if ($this->handle instanceof \PgSql\Connection || \is_resource($this->handle)) {
+            \pg_cancel_query($this->handle);
             \pg_close($this->handle);
             $this->handle = null;
         }

diff --git a/test/AbstractConnectTest.php b/test/AbstractConnectTest.php
@@ -66,4 +66,16 @@ public function testConnectInvalidUser(): Promise
 
         return $this->connect(PostgresConnectionConfig::fromString('host=localhost user=invalid'), new TimeoutCancellationToken(100));
     }
+
+    public function testConnectionClose(): \Generator
+    {
+        $connection = yield $this->connect(PostgresConnectionConfig::fromString('host=localhost user=postgres'));
+        $this->assertInstanceOf(Connection::class, $connection);
+
+        $connection->execute('SELECT pg_sleep(10)');
+
+        $start = microtime(true);
+        $connection->close();
+        $this->assertEquals(0, round(microtime(true) - $start));
+    }
 }