Wait until all streams closed

amphp · Nov 28, 2024 · fa8f729 · fa8f729
1 parent 4e391ab
commit fa8f729
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/src/Connection/Internal/Http2ConnectionProcessor.php b/src/Connection/Internal/Http2ConnectionProcessor.php
@@ -1382,12 +1382,15 @@ private function releaseStream(int $streamId, ?\Throwable $exception, bool $unpr
             }
         }
 
-        if ($this->shutdown !== null && $streamId === $this->lastStream) {
-            $this->socket->close();
-        }
+        if (!$this->streams) {
+            if ($this->shutdown !== null) {
+                $this->socket->close();
+                return;
+            }
 
-        if (!$this->streams && !$this->socket->isClosed() && $this->socket instanceof ResourceStream) {
-            $this->socket->unreference();
+            if ($this->socket instanceof ResourceStream) {
+                $this->socket->unreference();
+            }
         }
     }