Skip to content

Commit

Permalink
Update changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
rdlowrey committed Oct 27, 2014
1 parent 97f6c9a commit c4d67c6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
8 changes: 4 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
#### master
### v1.0.0-rc4

- SocketPool now properly observes host connection limits
- New `Client::OP_CONCURRENCY_LIMIT` setting queues outstanding requests beyond a certain number
(default 512) to help prevent naive applications from spiraling memory out of control without
worrying over the details of concurrency.

##### BC BREAKS:
> **BC BREAKS:**
- The `Client::OP_QUEUED_SOCKET_LIMIT` setting has been removed

Expand All @@ -32,7 +32,7 @@
- Issue #54: Fix bug preventing redirect if request method was not GET or HEAD
- Migrate to amphp framework

##### BC BREAKS:
> **BC BREAKS:**
- Because the library has been migrated to the amphp concurrency framework all `Artax` namespace
declarations in your code must be updated to `Amp\Artax`. Additionally, return values from both
Expand Down Expand Up @@ -79,7 +79,7 @@
- `Artax\Client` now implements `Artax\HttpClient` interface for simplified testing and composition support
- Updated examples

##### BC BREAKS:
> **BC BREAKS:**
- The breakage in this release is extensive as the entire library has been rewritten. **DO NOT**
upgrade your application to use this release and expect existing code to "just work." You have
Expand Down
1 change: 0 additions & 1 deletion lib/Client.php
Original file line number Diff line number Diff line change
Expand Up @@ -725,7 +725,6 @@ private function processDeadSocket(RequestCycle $cycle) {
$parsedResponseArr = $cycle->parser->getParsedMessageArray();
$this->assignParsedResponse($cycle, $parsedResponseArr);
} elseif ($parserState == Parser::AWAITING_HEADERS && empty($cycle->retryCount)) {
echo "\n\n --retry-- \n\n";
$this->retry($cycle);
} else {
$this->fail($cycle, new SocketException(
Expand Down

0 comments on commit c4d67c6

Please sign in to comment.