Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from conventional-changelog:master #13

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions @alias/commitlint-config-angular/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [17.7.0](https://github.com/conventional-changelog/commitlint/compare/v17.6.7...v17.7.0) (2023-08-09)

**Note:** Version bump only for package commitlint-config-angular





## [17.6.7](https://github.com/conventional-changelog/commitlint/compare/v17.6.6...v17.6.7) (2023-07-19)

**Note:** Version bump only for package commitlint-config-angular
Expand Down
4 changes: 2 additions & 2 deletions @alias/commitlint-config-angular/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "commitlint-config-angular",
"version": "17.6.7",
"version": "17.7.0",
"description": "Shareable commitlint config enforcing the angular commit convention",
"files": [
"index.js"
Expand Down Expand Up @@ -30,7 +30,7 @@
"node": ">=v14"
},
"dependencies": {
"@commitlint/config-angular": "^17.6.7"
"@commitlint/config-angular": "^17.7.0"
},
"devDependencies": {
"@commitlint/utils": "^17.4.0"
Expand Down
8 changes: 8 additions & 0 deletions @alias/commitlint-config-lerna-scopes/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [17.7.0](https://github.com/conventional-changelog/commitlint/compare/v17.6.7...v17.7.0) (2023-08-09)

**Note:** Version bump only for package commitlint-config-lerna-scopes





## [17.6.6](https://github.com/conventional-changelog/commitlint/compare/v17.6.5...v17.6.6) (2023-06-24)

**Note:** Version bump only for package commitlint-config-lerna-scopes
Expand Down
4 changes: 2 additions & 2 deletions @alias/commitlint-config-lerna-scopes/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "commitlint-config-lerna-scopes",
"version": "17.6.6",
"version": "17.7.0",
"description": "Shareable commitlint config enforcing lerna package names as scopes",
"files": [
"index.js"
Expand Down Expand Up @@ -30,7 +30,7 @@
"node": ">=v14"
},
"dependencies": {
"@commitlint/config-lerna-scopes": "^17.6.6"
"@commitlint/config-lerna-scopes": "^17.7.0"
},
"devDependencies": {
"@commitlint/utils": "^17.4.0"
Expand Down
8 changes: 8 additions & 0 deletions @alias/commitlint-config-patternplate/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [17.7.0](https://github.com/conventional-changelog/commitlint/compare/v17.6.7...v17.7.0) (2023-08-09)

**Note:** Version bump only for package commitlint-config-patternplate





## [17.6.7](https://github.com/conventional-changelog/commitlint/compare/v17.6.6...v17.6.7) (2023-07-19)

**Note:** Version bump only for package commitlint-config-patternplate
Expand Down
4 changes: 2 additions & 2 deletions @alias/commitlint-config-patternplate/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "commitlint-config-patternplate",
"version": "17.6.7",
"version": "17.7.0",
"description": "Lint your commits, patternplate-style",
"files": [
"index.js"
Expand Down Expand Up @@ -30,7 +30,7 @@
"node": ">=v14"
},
"dependencies": {
"@commitlint/config-patternplate": "^17.6.7"
"@commitlint/config-patternplate": "^17.7.0"
},
"devDependencies": {
"@commitlint/utils": "^17.4.0"
Expand Down
8 changes: 8 additions & 0 deletions @alias/commitlint/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [17.7.0](https://github.com/conventional-changelog/commitlint/compare/v17.6.7...v17.7.0) (2023-08-09)

**Note:** Version bump only for package commitlint





## [17.6.7](https://github.com/conventional-changelog/commitlint/compare/v17.6.6...v17.6.7) (2023-07-19)

**Note:** Version bump only for package commitlint
Expand Down
4 changes: 2 additions & 2 deletions @alias/commitlint/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "commitlint",
"version": "17.6.7",
"version": "17.7.0",
"description": "Lint your commit messages",
"files": [
"cli.js"
Expand Down Expand Up @@ -35,7 +35,7 @@
},
"license": "MIT",
"dependencies": {
"@commitlint/cli": "^17.6.7",
"@commitlint/cli": "^17.7.0",
"@commitlint/types": "^17.4.4"
},
"devDependencies": {
Expand Down
8 changes: 8 additions & 0 deletions @commitlint/cli/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [17.7.0](https://github.com/conventional-changelog/commitlint/compare/v17.6.7...v17.7.0) (2023-08-09)

**Note:** Version bump only for package @commitlint/cli





## [17.6.7](https://github.com/conventional-changelog/commitlint/compare/v17.6.6...v17.6.7) (2023-07-19)

**Note:** Version bump only for package @commitlint/cli
Expand Down
6 changes: 3 additions & 3 deletions @commitlint/cli/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@commitlint/cli",
"version": "17.6.7",
"version": "17.7.0",
"description": "Lint your commit messages",
"files": [
"index.js",
Expand Down Expand Up @@ -48,8 +48,8 @@
},
"dependencies": {
"@commitlint/format": "^17.4.4",
"@commitlint/lint": "^17.6.7",
"@commitlint/load": "^17.6.7",
"@commitlint/lint": "^17.7.0",
"@commitlint/load": "^17.7.0",
"@commitlint/read": "^17.5.1",
"@commitlint/types": "^17.4.4",
"execa": "^5.0.0",
Expand Down
52 changes: 26 additions & 26 deletions @commitlint/cli/src/cli.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ test('should produce help for problems', async () => {
const cwd = await gitBootstrap('fixtures/default');
const actual = await cli([], {cwd})('foo: bar');
expect(actual.stdout).toContain(
'Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint',
'Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint'
);
expect(actual.exitCode).toBe(1);
});
Expand All @@ -78,10 +78,10 @@ test('should produce help for problems with correct helpurl', async () => {
const cwd = await gitBootstrap('fixtures/default');
const actual = await cli(
['-H https://github.com/conventional-changelog/commitlint/#testhelpurl'],
{cwd},
{cwd}
)('foo: bar');
expect(actual.stdout).toContain(
'Get help: https://github.com/conventional-changelog/commitlint/#testhelpurl',
'Get help: https://github.com/conventional-changelog/commitlint/#testhelpurl'
);
expect(actual.exitCode).toBe(1);
});
Expand Down Expand Up @@ -152,7 +152,7 @@ test('should work with husky commitmsg hook and git commit', async () => {
const commit = await execa(
'git',
['commit', '-m', '"test: this should work"'],
{cwd},
{cwd}
);

expect(commit).toBeTruthy();
Expand All @@ -168,7 +168,7 @@ test('should work with husky commitmsg hook in sub packages', async () => {
const commit = await execa(
'git',
['commit', '-m', '"test: this should work"'],
{cwd},
{cwd}
);
expect(commit).toBeTruthy();
});
Expand All @@ -177,15 +177,15 @@ test('should work with husky via commitlint -e $GIT_PARAMS', async () => {
const cwd = await gitBootstrap('fixtures/husky/integration');
await writePkg(
{husky: {hooks: {'commit-msg': `'${bin}' -e $GIT_PARAMS`}}},
{cwd},
{cwd}
);

// await execa('npm', ['install'], {cwd}); // npm install is failing on windows machines
await execa('git', ['add', 'package.json'], {cwd});
const commit = await execa(
'git',
['commit', '-m', '"test: this should work"'],
{cwd},
{cwd}
);
expect(commit).toBeTruthy();
});
Expand All @@ -194,15 +194,15 @@ test('should work with husky via commitlint -e %GIT_PARAMS%', async () => {
const cwd = await gitBootstrap('fixtures/husky/integration');
await writePkg(
{husky: {hooks: {'commit-msg': `'${bin}' -e %GIT_PARAMS%`}}},
{cwd},
{cwd}
);

// await execa('npm', ['install'], {cwd}); // npm install is failing on windows machines
await execa('git', ['add', 'package.json'], {cwd});
const commit = await execa(
'git',
['commit', '-m', '"test: this should work"'],
{cwd},
{cwd}
);
expect(commit).toBeTruthy();
});
Expand All @@ -211,15 +211,15 @@ test('should work with husky via commitlint -e $HUSKY_GIT_PARAMS', async () => {
const cwd = await gitBootstrap('fixtures/husky/integration');
await writePkg(
{husky: {hooks: {'commit-msg': `'${bin}' -e $HUSKY_GIT_PARAMS`}}},
{cwd},
{cwd}
);

// await execa('npm', ['install'], {cwd}); // npm install is failing on windows machines
await execa('git', ['add', 'package.json'], {cwd});
const commit = await execa(
'git',
['commit', '-m', '"test: this should work"'],
{cwd},
{cwd}
);
expect(commit).toBeTruthy();
});
Expand All @@ -228,15 +228,15 @@ test('should work with husky via commitlint -e %HUSKY_GIT_PARAMS%', async () =>
const cwd = await gitBootstrap('fixtures/husky/integration');
await writePkg(
{husky: {hooks: {'commit-msg': `'${bin}' -e %HUSKY_GIT_PARAMS%`}}},
{cwd},
{cwd}
);

// await execa('npm', ['install'], {cwd}); // npm install is failing on windows machines
await execa('git', ['add', 'package.json'], {cwd});
const commit = await execa(
'git',
['commit', '-m', '"test: this should work"'],
{cwd},
{cwd}
);
expect(commit).toBeTruthy();
});
Expand All @@ -255,7 +255,7 @@ test('should allow reading of environment variables for edit file, failing if in
const cwd = await gitBootstrap('fixtures/simple');
await fs.writeFile(
path.join(cwd, 'commit-msg-file'),
'foo: bar\n\nFoo bar bizz buzz.\n\nCloses #123.',
'foo: bar\n\nFoo bar bizz buzz.\n\nCloses #123.'
);
const actual = await cli(['--env', 'variable'], {
cwd,
Expand All @@ -267,7 +267,7 @@ test('should allow reading of environment variables for edit file, failing if in
test('should pick up parser preset and fail accordingly', async () => {
const cwd = await gitBootstrap('fixtures/parser-preset');
const actual = await cli(['--parser-preset', './parser-preset'], {cwd})(
'type(scope): subject',
'type(scope): subject'
);
expect(actual.exitCode).toBe(1);
expect(actual.stdout).toContain('may not be empty');
Expand All @@ -276,7 +276,7 @@ test('should pick up parser preset and fail accordingly', async () => {
test('should pick up parser preset and succeed accordingly', async () => {
const cwd = await gitBootstrap('fixtures/parser-preset');
const actual = await cli(['--parser-preset', './parser-preset'], {cwd})(
'----type(scope): subject',
'----type(scope): subject'
);
expect(actual.exitCode).toBe(0);
});
Expand Down Expand Up @@ -322,7 +322,7 @@ test('should handle --amend with signoff', async () => {
await execa(
'git',
['commit', '-m', '"test: this should work"', '--signoff'],
{cwd},
{cwd}
);
const commit = await execa('git', ['commit', '--amend', '--no-edit'], {cwd});

Expand All @@ -342,7 +342,7 @@ test("it doesn't use parserOpts.commentChar when using edit mode", async () => {
const cwd = await gitBootstrap('fixtures/comment-char');
await fs.writeFile(
path.join(cwd, '.git', 'COMMIT_EDITMSG'),
'header: foo\n\n$body\n',
'header: foo\n\n$body\n'
);

const actual = await cli(['--edit', '.git/COMMIT_EDITMSG'], {cwd})();
Expand All @@ -355,7 +355,7 @@ test('it uses core.commentChar git config when using edit mode', async () => {
await execa('git', ['config', '--local', 'core.commentChar', '$'], {cwd});
await fs.writeFile(
path.join(cwd, '.git', 'COMMIT_EDITMSG'),
'header: foo\n\n$body\n',
'header: foo\n\n$body\n'
);

const actual = await cli(['--edit', '.git/COMMIT_EDITMSG'], {cwd})();
Expand All @@ -367,7 +367,7 @@ test('it falls back to # for core.commentChar when using edit mode', async () =>
const cwd = await gitBootstrap('fixtures/comment-char');
await fs.writeFile(
path.join(cwd, '.git', 'COMMIT_EDITMSG'),
'header: foo\n\n#body\n',
'header: foo\n\n#body\n'
);

const actual = await cli(['--edit', '.git/COMMIT_EDITMSG'], {cwd})();
Expand Down Expand Up @@ -408,7 +408,7 @@ test('should fail for invalid formatters from configuration', async () => {
const actual = await cli([], {cwd})('foo: bar');

expect(actual.stderr).toContain(
'Using format custom-formatter, but cannot find the module',
'Using format custom-formatter, but cannot find the module'
);
expect(actual.stdout).toEqual('');
expect(actual.exitCode).toBe(1);
Expand Down Expand Up @@ -449,7 +449,7 @@ test('should fail for invalid formatters from flags', async () => {
const actual = await cli(['--format', 'through-flag'], {cwd})('foo: bar');

expect(actual.stderr).toContain(
'Using format through-flag, but cannot find the module',
'Using format through-flag, but cannot find the module'
);
expect(actual.stdout).toEqual('');
expect(actual.exitCode).toBe(1);
Expand All @@ -458,11 +458,11 @@ test('should fail for invalid formatters from flags', async () => {
test('should work with absolute formatter path', async () => {
const formatterPath = path.resolve(
__dirname,
'../fixtures/custom-formatter/formatters/custom.js',
'../fixtures/custom-formatter/formatters/custom.js'
);
const cwd = await gitBootstrap('fixtures/custom-formatter');
const actual = await cli(['--format', formatterPath], {cwd})(
'test: this should work',
'test: this should work'
);

expect(actual.stdout).toContain('custom-formatter-ok');
Expand All @@ -472,10 +472,10 @@ test('should work with absolute formatter path', async () => {
test('should work with relative formatter path', async () => {
const cwd = path.resolve(
await gitBootstrap('fixtures/custom-formatter'),
'./formatters',
'./formatters'
);
const actual = await cli(['--format', './custom.js'], {cwd})(
'test: this should work',
'test: this should work'
);

expect(actual.stdout).toContain('custom-formatter-ok');
Expand Down
Loading