Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy/Item component #573

Merged
merged 11 commits into from
Apr 21, 2019
Merged

Tidy/Item component #573

merged 11 commits into from
Apr 21, 2019

Conversation

pedroabreu
Copy link
Contributor

No description provided.

@pedroabreu pedroabreu changed the title CSS text-ellipsis of summary Tidy/Item component Apr 21, 2019
amilajack
amilajack requested changes Apr 21, 2019
View reviewed changes
app/components/item/description.js Outdated Show resolved Hide resolved
amilajack
amilajack approved these changes Apr 21, 2019
View reviewed changes
Copy link
Owner

@amilajack amilajack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff 🎉

@amilajack amilajack changed the base branch from master to next April 21, 2019 22:25
@amilajack
Copy link
Owner

Thank you so much for the awesome PRs! I was wondering if you would be interested in working on #282. This bug causes a terrible user experience, especially when you're scrolling through many pages of movies, click on a movie, and then click the back button and then have to scroll all the way down again.

@amilajack amilajack merged commit 320eded into amilajack:next Apr 21, 2019
@amilajack
Copy link
Owner

This seems to have introduce a small bug with the torrent seeder count color. This should be green:

Screen Shot 2019-04-21 at 3 44 03 PM

@pedroabreu
Copy link
Contributor Author

Logic is the same for the icon color 🤔 Is it possible it was already there ? Only thing I can think of is that the health property doesn't respect the expected string values

@pedroabreu pedroabreu deleted the tidy/item branch April 21, 2019 22:49
@amilajack
Copy link
Owner

It might have been there already. May have been introduced by #575.

amilajack pushed a commit that referenced this pull request Apr 21, 2019
@pedroabreu @amilajack
Tidy/Item component (#573)
393e563 
* CSS text-ellipsis of item summary

* No need to wrap event props

* Fix summary test

* CSS solution for torrent health

* Use uncontrolled tooltip

* Use uncontrolled dropdown

* Read playback information from state directly

* description component

* Remove unused state vars

* use data-e2e attribute

* Capitalize react component filename
@pedroabreu pedroabreu mentioned this pull request Apr 22, 2019
Closed
@pedroabreu
Copy link
Contributor Author

I think it's even before that. It's related to the way the health is set, depending on ratio and not just number of seeders.

So, if the ratio is < 1, it will always set poor quality, regardless of the number of seeders

@amilajack
Copy link
Owner

I fixed it yesterday. Turned out to be a small typo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amilajack amilajack amilajack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedroabreu @amilajack