Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: minor dx improvements #46

Merged
merged 5 commits into from
Apr 22, 2024
Merged

refactor: minor dx improvements #46

merged 5 commits into from
Apr 22, 2024

Conversation

giulianok
Copy link
Member

@giulianok giulianok commented Jan 11, 2024 •
edited by PixnBits
Loading

This PR include many minor improvements:

  1. Bumped and tested Node v20. Minimum version v18
  2. Do not log an error when the user exits the prompt, instead, render "bye bye"
  3. Dependencies must be upgraded to resolve npm audit vulnerabilities
    Screenshot 2024-01-10 at 4 42 56 PM

@giulianok giulianok requested review from a team as code owners January 11, 2024 02:08
@giulianok giulianok force-pushed the refactor/minor-improvements branch 2 times, most recently from bc30b44 to 3c22e63 Compare January 12, 2024 14:53
JAdshead
JAdshead reviewed Jan 12, 2024
View reviewed changes
bin/index.js Outdated Show resolved Hide resolved
@giulianok giulianok force-pushed the refactor/minor-improvements branch from 3c22e63 to 58e0d52 Compare January 16, 2024 16:27
guym4c
guym4c previously approved these changes Feb 7, 2024
View reviewed changes
src/utils/prompts.js Outdated Show resolved Hide resolved
10xLaCroixDrinker
10xLaCroixDrinker requested changes Mar 14, 2024
View reviewed changes
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
__tests__/bin/index.spec.js Show resolved Hide resolved
@10xLaCroixDrinker
Copy link
Member

@giulianok are you still working on this?

@code-forger
Copy link
Member

Closed with no activity in 2 weeks

@giulianok
Copy link
Member Author

feedbacks has been addressed

@giulianok giulianok reopened this Apr 19, 2024
@giulianok giulianok force-pushed the refactor/minor-improvements branch from 9aad642 to 4c36f1a Compare April 22, 2024 17:26
@giulianok giulianok merged commit 3be9b05 into main Apr 22, 2024
3 checks passed
@giulianok giulianok deleted the refactor/minor-improvements branch April 22, 2024 17:28
@oneamexbot
Copy link
Contributor

🎉 This PR is included in version 1.11.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@10xLaCroixDrinker 10xLaCroixDrinker 10xLaCroixDrinker approved these changes

@Matthew-Mallimo Matthew-Mallimo Matthew-Mallimo approved these changes

@guym4c guym4c Awaiting requested review from guym4c

@JAdshead JAdshead Awaiting requested review from JAdshead

Assignees
No one assigned
Labels
one-app-team-review-requested released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@giulianok @10xLaCroixDrinker @code-forger @oneamexbot @guym4c @JAdshead @Matthew-Mallimo