Added logic to skip firstLine response header if HTTP 2.0 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to support HTTP/1.1 and HTTP/2.0 requests.
The HTTP 1.1 version of the response header begins with the format
<HTTP Version><response code><status>(Ex. 'HTTP/1.1 200 OK' ).When exporting a Charles JSON Session File this first line is stored under the
firstLinekey. The script is explicitly searching for thefirstLinekey when doing its processing of the Charles JSON Session File.I noticed that HTTP 2.0 response headers do not begin with this line so the script returns a
KeyErrorwhen trying to process a Charles JSON Session File that has HTTP 2.0 requests.I added a try/except block to skip this processing if the
firstLinekey does not exist