-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws: add support for EKS Pod Identity #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look to be contained within the files/methods modified, appropriate test cases are added, changes were tested in EKS contexts, and code is near-equivalent to the upstream pr which was also tested by upstream maintainers.
Need to wait for the ongoing CVE update release to get pushed to stable before merging this, otherwise approved.
Fluent Bit will not publish telemetry to CloudWatch when only EKS pod identity credential is present. This is because it does not use EKS pod identity as part of its credential provider chain.
We are making a change to Fluent Bit's AWS HTTPS credential functions to use the token provided in environment variable
AWS_CONTAINER_AUTHORIZATION_TOKEN_FILE
which is injected by EKS Pod Identity webhook to query endpoint specified inAWS_CONTAINER_CREDENTIALS_FULL_URI
environment variable to retrieve STS credentials.This PR is a replica of fluent#9206 but merging the changes from @PettitWesley and @edsiper and also making minor changes to comments, unit tests, and variable naming.
Address aws/aws-for-fluent-bit#784
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
Used default configuration provided by AWS CloudWatch Observability add-on
Log output after adding proper IAM permissions to role associated with pod identity
Log output after removing proper IAM permissions to role associated with pod identity
Ran valgrind against HTTP credentail tests
Command
Output
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.