fix(cicd): improved dependency of jobs for publish and release

alvyn279 · May 9, 2021 · b52fe0e · b52fe0e
1 parent 2bdae2f
commit b52fe0e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -7,7 +7,7 @@ on:
     branches: [ main ]
 
 jobs:
-  build_lint_test:
+  lint_build_test:
     runs-on: ubuntu-latest
     strategy:
       matrix:
@@ -25,11 +25,11 @@ jobs:
       - name: Install dependencies
         run: npm i
 
-      - name: Build lib
-        run: npm run build
-
       - name: Run linter
         run: npm run lint
 
+      - name: Build lib
+        run: npm run build
+
       - name: Run unit tests
         run: npm test
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -6,7 +6,8 @@ on:
       - "v*"
 
 jobs:
-  build_and_publish: # publish to package managers
+  # publish to package managers
+  build_and_publish:
     runs-on: ubuntu-latest
 
     steps:
@@ -40,7 +41,9 @@ jobs:
         with:
           PYPI_TOKEN: ${{ secrets.PYPI_TOKEN }}
 
-  release: # release versioned source code to GitHub
+  # release versioned source code to GitHub
+  release:
+    needs: build_and_publish
     runs-on: ubuntu-latest
 
     steps: