Merge pull request #385 from alphagov/remove-jasmine-ruby-gem

Remove jasmine ruby gem and its requiring
alphagov · Jan 21, 2025 · d41b0d5 · d41b0d5
2 parents 58e7c76 + a7dc7dc
commit d41b0d5
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/Rakefile b/Rakefile
@@ -1,6 +1,5 @@
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
-require "jasmine"
 
 RSpec::Core::RakeTask.new(:spec)
 

diff --git a/govuk_tech_docs.gemspec b/govuk_tech_docs.gemspec
@@ -39,6 +39,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency "base64" # TODO: remove once middleman-sprockets declares this itself.
   spec.add_dependency "bigdecimal" # TODO: remove once activesupport declares this itself.
   spec.add_dependency "chronic", "~> 0.10.2"
+  spec.add_dependency "concurrent-ruby", "1.3.4" # 1.3.5 introduced a change that breaks activesupport, and so middleman
   spec.add_dependency "csv" # TODO: remove once tilt declares this itself.
   spec.add_dependency "haml", "~> 6.0"
   spec.add_dependency "middleman", "~> 4.0"
@@ -57,7 +58,6 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "byebug"
   spec.add_development_dependency "capybara", "~> 3.32"
-  spec.add_development_dependency "jasmine", "~> 3.5"
   spec.add_development_dependency "rake", "~> 13.0"
   spec.add_development_dependency "rspec", "~> 3.9"
   spec.add_development_dependency "rubocop-govuk", "~> 4.10"