Migrate to Dart Sass #1108
Merged
Migrate to Dart Sass #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create .keep - Update manifest file to use /builds directory - Ignore /builds - Add initiliser which supresses dependency deprecation warnings
When i deployed this out to integration for testing it didn't seem to running Dass Sart's build command when running assets precompile. This resolves the issue.
davidgisbey
force-pushed
the
migrate-to-dartsass
branch
from
5138747 to
97432d4
Compare
ryanb-gds
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LibSass has been deprecated. We're moving to Dart Sass. This follows the upgrade guide found here
https://docs.publishing.service.gov.uk/manual/migrate-to-dart-sass-from-libsass.html
Trello card
https://trello.com/c/qeNHFPZN/1667-migrate-to-dart-sass
Follow these steps if you are doing a Rails upgrade.