Improve Implementation Guide page titles and meta descriptions #4977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
changed the title
AshGDS
reviewed
Jan 31, 2025
There was a problem hiding this comment.
Looks OK to me 👍 , but I've noticed two things:
- We're using the old GOVUK Crown, since you're modifying the analytics layout already would you like to include that change in this repo?
- The social media preview image no longer exists: https://docs.publishing.service.gov.uk/images/govuk-large.png
No worries if you think they should be done in separate PRs.
|
@AshGDS I think best done in a separate PR. Not sure who's responsible for maintenance of the docs but probably something in their remit. |
AshGDS
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
@andysellick OK - it looks like the crown is only wrong on the analytics docs though, so it would probably come back to us. The repo is owned by #govuk-developers so I think the responsibility is for everyone to manage it. Do you want me to look into fixing these?
|
@AshGDS sorry, didn't quite get that, yes I'll take a look, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Improves page titles and adds metadata descriptions for the analytics section of the dev docs.
Why
Previously no meta descriptions, so sharing pages didn't provide enough information.
Visual changes
None.
Trello: https://trello.com/c/PmI26YFF/839-update-ga4-implementation-record-page-titles