Reconfigure HTML publication titles #3534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshGDS
approved these changes
Jan 27, 2025
- adjust options on inverse header following change, setting padding and use subtext in place of hard coded para and application level styles - replace title component with heading component
andysellick
force-pushed
the
inverse-header
branch
from
42ce846 to
88633bc
Compare
andysellick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Reconfigure the use of the inverse header on HTML publication pages e.g. https://www.gov.uk/government/publications/benefit-and-pension-rates-2025-to-2026/benefit-and-pension-rates-2025-to-2026, specifically:
There's a failing test in this PR but testing locally suggests that it'll be fixed with a new version of the components gem containing the associated change.
Why
The options in the inverse header component have been changed, see alphagov/govuk_publishing_components#4590
Also we're trying to get rid of the title component, to be replaced by the heading component.
Note that this change will not be merged until a new version of the components gem including this change is included here.
Visual changes
No visual changes on desktop, but the mobile version is a little tighter as a result, but I think this is fine.
Trello card: https://trello.com/c/hRL2Nmyp/450-improve-inverse-header-component-padding