Remove duplicate headers #2775
Merged
Remove duplicate headers #2775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 25, 2021
Merged
This was referenced Jun 21, 2021
alex-ju
approved these changes
Aug 20, 2021
Header is already used in the top bar, this duplicate is unnecessary, and while not invalid, and an a11y concern as header a landmark role
chris-gds
force-pushed
the
remove-duplicate-headers
branch
from
28991ea to
b8520bc
Compare
|
@maxgds any chance you could merge this one? Don't have the auth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removing duplicate
<header>s from pagesWhy
As part of the PR swapping the page layout to the gem, pages were checked for errors. An A11y concern was noted, multiple headers were in use that don't align with other pages or the Design System. While valid could cause confusion.
Visuals
No visual changes.
Testing
Sample of pages impacted