Replace cgi and logging.warn with new APIs
#292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlassOfWhiskey
changed the title
cgi and logging.warn with new APIs
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #292 +/- ##
==========================================
+ Coverage 65.68% 65.87% +0.19%
==========================================
Files 82 82
Lines 10144 10149 +5
Branches 2397 2399 +2
==========================================
+ Hits 6663 6686 +23
+ Misses 3050 3029 -21
- Partials 431 434 +3 ☔ View full report in Codecov by Sentry. |
GlassOfWhiskey
force-pushed
the
remove-deprecated-functions
branch
5 times, most recently
from
831d784 to
4450053
Compare
The `cgi` Python module has been deprecated in PEP 594. In particular, the `parse_header` function has been deprecated in favor of the new `email.message.Message` API. This commit replaces all occurrences of `parse_header` with the new API. This commit also adds a test for the `remotepath.download` API to avoid regressions. As of Python 3.3, the `logging.warn` API has been deprected in favor of the `logging.warning` method. This commit substitutes all occurrences of the `warn()` method with the equivalent `warning()` API.
GlassOfWhiskey
force-pushed
the
remove-deprecated-functions
branch
from
4450053 to
ad391ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cgiPython module has been deprecated in PEP 594. In particular, theparse_headerfunction has been deprecated in favor of the newemail.message.MessageAPI. This commit replaces all occurrences ofparse_headerwith the new API.As of Python 3.3, the
logging.warnAPI has been deprected in favor of thelogging.warningmethod. This commit substitutes all occurrences of thewarn()method with the equivalentwarning()API.