feat(sol!): make #[sol(rpc)] default if rpc feat enabled
#852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
requested review from
DaniPopes,
gakonst and
mattsse
as code owners
yash-atreya
changed the title
sol-macro-expander): make #[sol(rpc)] defaultsol!): make #[sol(rpc)] default
gakonst
reviewed
Jan 9, 2025
DaniPopes
requested changes
Jan 9, 2025
There was a problem hiding this comment.
Sorry but I disagree with this, just like with adding derives by default, this makes compilation a lot slower and it's counterintuitive to how the rest of the ecosystem works: derives are opt-in for extra functionality
The default codegen requires the minimum dependencies. RPC codegen is straight up not possible in many contexts like no_std, so this is also a breaking change.
yash-atreya
changed the title
sol!): make #[sol(rpc)] defaultsol!): make #[sol(rpc)] default if rpc feat enabled
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently when expanding contracts in the
sol!therpcattribute is not enabled by default. Users must explicitly enable using#[sol(rpc)].Solution
Introduces
"rpc"feature that is propagated fromalloy-coretoalloy-sol-macro-expander.Enabling this feature expands the contract with RPC-related code.
Now, one can make use of
ContractInstance::new(addr, provider)without having to specify#[sol(rpc)].RPC-related methods can be disabled using
#[sol(rpc = false)].Note: Enabling this by default requires the user to install
alloy-contract.PR Checklist