Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kush/upgrade changes #60

Merged
merged 7 commits into from
Sep 5, 2024
Merged

Kush/upgrade changes #60

merged 7 commits into from
Sep 5, 2024

Conversation

kush-alloralabs
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for alloradocs ready!

Name Link
🔨 Latest commit 7fd5d5b
🔍 Latest deploy log https://app.netlify.com/sites/alloradocs/deploys/66d9befc3178690008d8db73
😎 Deploy Preview https://deploy-preview-60--alloradocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kush-alloralabs kush-alloralabs merged commit 4e8ddb4 into main Sep 5, 2024
5 checks passed
@kush-alloralabs kush-alloralabs deleted the kush/upgrade-changes branch September 5, 2024 15:09
Copy link

@xmariachi xmariachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, otherwise lgtm

@@ -38,6 +38,10 @@ type MsgCreateNewTopic struct {
AllowNegative bool `json:"allow_negative,omitempty"`
// the numerical precision at which the network should distinguish differences in the logarithm of the loss
Epsilon github_com_allora_network_allora_chain_math.Dec `json:"epsilon"`
MeritSortitionAlpha github_com_allora_network_allora_chain_math.Dec `json:"merit_sortition_alpha"`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are comments in the other fields, seems proper to add them here too.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MeritSortitionAlpha:
// alpha parameter to weight previous score EMA importance in filtering the active set of inferers, forecasters, and reputers

ActiveXQuantile
// marks the quantile of lower Xs by score on the active set that may be replaced by new Xs each epoch

"loss-calculation-eth.wasm" \ # LossMethod
"bafybeigpiwl3o73zvvl6dxdqu7zqcub5mhg65jiky2xqb4rdhfmikswzqm" \ # InferenceLogic
"allora-inference-function.wasm" \ # InferenceMethod
"mse" \ # LossMethod
3600 \ # EpochLength
0 \ # GroundTruthLag

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ground Truth lag should be at least EpochLength. Using EpochLength lgtm as an example here. Most if not all of our topics are defined like that.

3600 \ # EpochLength
0 \ # GroundTruthLag
"ETH" # DefaultArg
3 \ # WorkerSubmissionWindow

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worker submission window suggested to be 12 at least.
This is 12 blocks of time we leave workers to make submissions.
As this is an example this can be set to 36 safely (1% of the EpochLength).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants