Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incoming value limiting with exponent (with migration) #757

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

xmariachi
Copy link
Contributor

@xmariachi xmariachi commented Mar 4, 2025

Purpose of Changes and their Description

  • Added DataLimitExponent to limit the size and precision of the incoming data. Generous enough to avoid under/overflows.
  • Migration to v0.10.0 with tests
  • Fixed v2 migration Params (added old and new types for v1 and v2) - it was failing due to the Params usage on validations.
  • Added validations on incoming data with new validation_test.go.
  • Unit tests to ensure on keeper incoming data InsertInference / InsertForecasts / InsertLosses.

Are these changes tested and documented?

  • If tested, please describe how. If not, why tests are not needed.
    Tested via: existing unit tests, added unit tests for logic and migration, and also run the full migration using upgrade_test.go successfully. ✅
  • If documented, please describe where. If not, describe why docs are not needed. -- added in README on inf synth.
  • Added to Unreleased section of CHANGELOG.md?

Copy link

github-actions bot commented Mar 6, 2025

The latest Buf updates on your PR. Results from workflow Buf Linter / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed⏩ skippedMar 6, 2025, 9:01 PM

@xmariachi xmariachi changed the title WIP Inf value limiting Incoming value limiting with migration Mar 6, 2025
@xmariachi xmariachi changed the title Incoming value limiting with migration Incoming value limiting with exponent (with migration) Mar 6, 2025
@xmariachi xmariachi marked this pull request as ready for review March 6, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant