Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicate setting of reverse connect to objects #1825

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Removed duplicate setting of reverse connect to objects #1825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
353ca8c
Removed duplicate setting of reverse connect to objects
oblodgett Feb 7, 2025
55d235f
Some have eco codes
oblodgett Feb 7, 2025
5c4f12e
Updated the short cut
oblodgett Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions ...cegenome/curation_api/services/associations/agmAssociations/AgmAgmAssociationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,6 @@ protected void init() {
@Transactional
public AgmAgmAssociation upsert(AgmAgmAssociationDTO dto, BackendBulkDataProvider dataProvider) throws ValidationException {
AgmAgmAssociation association = agmAgmAssociationDtoValidator.validateAgmAgmAssociationDTO(dto, dataProvider);
if (association != null) {
addAssociationToAgm(association);
addAssociationToStr(association);
}

return association;
}

Expand Down
5 changes: 0 additions & 5 deletions ...cegenome/curation_api/services/associations/agmAssociations/AgmStrAssociationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,6 @@ protected void init() {
@Transactional
public AgmSequenceTargetingReagentAssociation upsert(AgmSequenceTargetingReagentAssociationDTO dto, BackendBulkDataProvider dataProvider) throws ValidationException {
AgmSequenceTargetingReagentAssociation association = agmStrAssociationDtoValidator.validateAgmSequenceTargetingReagentAssociationDTO(dto, dataProvider);
if (association != null) {
addAssociationToAgm(association);
addAssociationToStr(association);
}

return association;
}

Expand Down
7 changes: 0 additions & 7 deletions ...e/curation_api/services/associations/alleleAssociations/AlleleGeneAssociationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,6 @@ public ObjectResponse<AlleleGeneAssociation> upsert(AlleleGeneAssociation uiEnti
return null;
}
dbEntity = alleleGeneAssociationDAO.persist(dbEntity);
addAssociationToAllele(dbEntity);
oblodgett marked this conversation as resolved.
Show resolved Hide resolved
addAssociationToGene(dbEntity);
return new ObjectResponse<AlleleGeneAssociation>(dbEntity);
}

Expand All @@ -74,11 +72,6 @@ public ObjectResponse<AlleleGeneAssociation> validate(AlleleGeneAssociation uiEn
@Transactional
public AlleleGeneAssociation upsert(AlleleGeneAssociationDTO dto, BackendBulkDataProvider dataProvider) throws ValidationException {
AlleleGeneAssociation association = alleleGeneAssociationDtoValidator.validateAlleleGeneAssociationDTO(dto, dataProvider);
if (association != null) {
addAssociationToAllele(association);
addAssociationToGene(association);
}

return association;
}

Expand Down
4 changes: 0 additions & 4 deletions ...services/associations/constructAssociations/ConstructGenomicEntityAssociationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,6 @@ public ObjectResponse<ConstructGenomicEntityAssociation> upsert(ConstructGenomic
return null;
}
dbEntity = constructGenomicEntityAssociationDAO.persist(dbEntity);
/*
addAssociationToConstruct(dbEntity);
addAssociationToGenomicEntity(dbEntity);
*/
return new ObjectResponse<>(dbEntity);
}

Expand Down
Loading