Close output buffer when exception occurs during setup #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlh01
force-pushed
the
feature/catch-setup-exceptions
branch
2 times, most recently
from
b1babf3 to
ec56cf6
Compare
dlh01
force-pushed
the
feature/catch-setup-exceptions
branch
from
ec56cf6 to
9158273
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a test that makes a
GETrequest and expects an exception to be thrown during theparse_requestaction, which fires as part ofPending_Testable_Request::setup_wordpress_query().The exception is thrown, but the output buffer started just before then remains open, leading to a PHPUnit "risky test" warning:
Test code or tested code did not (only) close its own output buffers. This PR makes sure the buffer is closed.