Change to support PHPUnit 10 #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Auto Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the TipsChat with CodeRabbit Bot (
|
This reverts commit 6506aa3.
attackant
approved these changes
Nov 21, 2023
| @@ -7,7 +7,7 @@ | |||
| use Mantle\Testing\Framework_Test_Case; | |||
| use Predis\Connection\ConnectionException; | |||
|
|
|||
| class Test_Cache_Manager extends Framework_Test_Case { | |||
| class CacheManagerTest extends Framework_Test_Case { | |||
There was a problem hiding this comment.
I am not sure I like the Pascal case... I must be getting old. New things 😨
| @@ -21,7 +21,7 @@ trait Example_Overload { | |||
| * This method should be run during the setUpBeforeClass method of | |||
| * the Test_Case. | |||
| */ | |||
| public static function example_overload_set_up_before_class(): void { | |||
| public static function exampleoverload_set_up_before_class(): void { | |||
| static::$overloaded_methods[] = 'setUpBeforeClass'; | |||
srtfisher
added a commit
that referenced
this pull request
Nov 21, 2023
* Including support for PHPUnit 10 * Upping to nunomaduro/collision * Migrating phpunit config * Upgrading annotation reader for PHPUnit 10.x * Adding PSR-4 autoloader dev * WIP on conversion script * Work to support the PSR4 migration * Script to convert to PSR4 * Extend to collision 6 for older versions * Bump asset manager * Change to support PHPUnit 10 (#473)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in the test suite to support PHPUnit 10. Broken out from #427 due to the size.