Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle spaces after Version in a plugin header when finding a package version #69

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Handle spaces after Version in a plugin header when finding a package version #69

merged 1 commit into from
Jan 3, 2024

Conversation

srtfisher
Copy link
Member

@srtfisher srtfisher commented Jan 3, 2024 •
edited
Loading

Ensure that the following header is properly matched against:

/*
 * Plugin Name: Publish to Apple News
 * Plugin URI:  http://github.com/alleyinteractive/apple-news
 * Description: Export and sync posts to Apple format.
 * Version:     2.4.1
 * Author:      Alley
 * Author URI:  https://alley.co
 * Text Domain: apple-news
 * Domain Path: lang/
 */

Also ensures that it properly falls back to package.json/composer.json if the header isn't found.

attackant
attackant approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@attackant attackant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐙

@attackant attackant merged commit 1742b97 into main Jan 3, 2024
2 checks passed
@attackant attackant deleted the hotfix/release-version branch January 3, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attackant attackant attackant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srtfisher @attackant