Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: minor change #1255

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix: minor change #1255

wants to merge 4 commits into from

Conversation

Poafs1
Copy link
Collaborator

@Poafs1 Poafs1 commented Feb 27, 2025

Summary by CodeRabbit

  • New Features

    • Improved layout scrolling behavior: Scrollbars now appear only when needed for a cleaner interface.
    • Enhanced contract details display: Implementation addresses are now presented as a navigable link to improve user interaction.
    • Expanded configuration options with new constants for username module address and LCD.
  • Documentation

    • Updated the changelog to reflect these interface improvements.

Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 6:55am
initia-celatone-rehearsal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 6:55am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
celatone-frontend-main ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2025 6:55am
initia-celatone-frontend ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2025 6:55am
neutron-celatone-frontend ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2025 6:55am
osmosis-celatone-frontend ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2025 6:55am
sei-celatone-frontend ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2025 6:55am
terra-celatone-frontend ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2025 6:55am

Copy link

coderabbitai bot commented Feb 27, 2025

Walkthrough

This update introduces a documentation change in the CHANGELOG.md, a layout update in the grid component to conditionally display scrollbars, and a user interface modification in the EVM contract details page. Specifically, the changelog now documents the removal of a layout scrollbar and the implementation address link, the grid's overflowY property is changed from "scroll" to "auto", and the CopyLink component is replaced by the ExplorerLink component with new properties. Additionally, new constants are introduced in the environment configuration.

Changes

File Change Summary
CHANGELOG.md Appended a bullet point in the "Improvements" section referencing PR #1255 for removing the layout scrollbar and implementation address link.
src/lib/layout/index.tsx Updated Grid component's overflowY property from "scroll" to "auto" to display scrollbars only when content overflows.
src/lib/pages/evm-contract-details/.../EvmContractDetailsTop.tsx Replaced CopyLink with ExplorerLink for displaying the proxyTargetAddress, updating props accordingly. Added the ExplorerLink component in the codebase.
src/env.ts Added new constants: INITIA_USERNAME_MODULE_ADDRESS and INITIA_USERNAME_LCD, retrieving values from environment variables.
src/lib/services/username/lcd.ts Removed constants INITIATION_2_LCD and USERNAME_MODULE_ADDRESS; replaced with imported constants INITIA_USERNAME_LCD and INITIA_USERNAME_MODULE_ADDRESS.
src/lib/pages/evm-contract-verify/index.tsx Modified queryKey in invalidateQueries to remove contractAddress, altering query invalidation criteria.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant E as EvmContractDetailsTop
    participant EL as ExplorerLink
    participant BE as Blockchain Explorer

    U->>E: Load contract details page
    E->>EL: Render proxyTargetAddress with ExplorerLink
    U->>EL: Click the address link
    EL->>BE: Navigate to explorer page
Loading

Suggested reviewers

  • evilpeach

Poem

I’m a rabbit with hops so light,
Coding through the day and night.
Scrollbars vanish with a swift new beat,
Links now lead to where explorers meet.
In the code field, we frolic and cheer,
Changes bloom—hip, hip, and dear!
🐇💻 Hop along and code with cheer!

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/lib/services/username/lcd.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-import".

(The package "eslint-plugin-import" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-import@latest --save-dev

The plugin "eslint-plugin-import" was referenced from the config file in ".eslintrc.json".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

src/env.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-import".

(The package "eslint-plugin-import" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-import@latest --save-dev

The plugin "eslint-plugin-import" was referenced from the config file in ".eslintrc.json".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

src/lib/pages/evm-contract-verify/index.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-import".

(The package "eslint-plugin-import" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-import@latest --save-dev

The plugin "eslint-plugin-import" was referenced from the config file in ".eslintrc.json".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a093750 and d4f7830.

📒 Files selected for processing (3)
  • src/env.ts (1 hunks)
  • src/lib/pages/evm-contract-verify/index.tsx (1 hunks)
  • src/lib/services/username/lcd.ts (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (6)
src/env.ts (2)

25-26: Implementation of environment variable configuration looks good.

This addition of the INITIA_USERNAME_MODULE_ADDRESS constant follows the established pattern in the file for retrieving values from environment variables with a fallback to an empty string.


28-29: Implementation of environment variable configuration looks good.

This addition of the INITIA_USERNAME_LCD constant follows the established pattern in the file for retrieving values from environment variables with a fallback to an empty string.

src/lib/services/username/lcd.ts (3)

1-1: Good refactoring of imports.

Importing the constants from the centralized env.ts file helps to improve maintainability and configurability.


9-10: Clean implementation of updated constants.

The refactoring to use the imported constants maintains the same functionality while improving code organization. The type assertion for INITIA_USERNAME_MODULE_ADDRESS as HexAddr32 is properly retained.


19-20: Clean implementation of updated constants.

The refactoring to use the imported constants in the getAddressByInitiaUsername function maintains the same functionality while improving code organization. The type assertion is properly retained.

src/lib/pages/evm-contract-verify/index.tsx (1)

216-216: Verify the intention behind broadening the query invalidation scope.

The change removes contractAddress from the query invalidation key, which means that after a successful verification, the cache will now invalidate verification statuses for all contracts on the current chain instead of just the specific contract being verified. Is this broader invalidation intentional?

The previous implementation likely looked like:

- queryKey: [CELATONE_QUERY_KEYS.EVM_VERIFY_INFOS, currentChainId, contractAddress],
+ queryKey: [CELATONE_QUERY_KEYS.EVM_VERIFY_INFOS, currentChainId],

While this change simplifies the code, it may cause unnecessary refetches for other contracts' verification statuses when only one contract is verified.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants