Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: update verify contract layout #1230

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

Poafs1
Copy link
Collaborator

@Poafs1 Poafs1 commented Feb 11, 2025

Summary by CodeRabbit

  • Style
    • Improved footer layout with sticky positioning, enhanced border, and padding for a more defined look.
    • Adjusted the main grid's maximum width for a more compact and streamlined interface design.
  • Documentation
    • Updated CHANGELOG.md to reflect the new feature regarding the EVM contract verification max width layout.

Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 11:18am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
celatone-frontend-main ⬜️ Ignored (Inspect) Visit Preview Feb 11, 2025 11:18am
initia-celatone-frontend ⬜️ Ignored (Inspect) Visit Preview Feb 11, 2025 11:18am
neutron-celatone-frontend ⬜️ Ignored (Inspect) Visit Preview Feb 11, 2025 11:18am
osmosis-celatone-frontend ⬜️ Ignored (Inspect) Visit Preview Feb 11, 2025 11:18am
sei-celatone-frontend ⬜️ Ignored (Inspect) Visit Preview Feb 11, 2025 11:18am
terra-celatone-frontend ⬜️ Ignored (Inspect) Visit Preview Feb 11, 2025 11:18am

Copy link

coderabbitai bot commented Feb 11, 2025

Walkthrough

This pull request adjusts the layout of the EVM contract verification pages. A new Box wrapper with sticky positioning and additional styling has been added around the footer CTA component. The styling of the FooterCta is updated with a maximum width of "1080px", centered horizontally, and an explicit column gap. Additionally, the maximum width of the grid layout in the main verification page has been reduced from "1440px" to "1080px". No changes have been made to the functional logic or to public API declarations.

Changes

File(s) Change Summary
src/lib/pages/evm-contract-verify/components/EvmContractVerifyFooter.tsx Added a Box wrapper with sticky positioning, top border, and padding around FooterCta. Updated FooterCta styling with maxW: "1080px", centered margin, and a columnGap of "32px".
src/lib/pages/evm-contract-verify/index.tsx Modified the Grid component’s maxW property from "1440px" to "1080px" to create a more compact layout.
CHANGELOG.md Added a new feature entry for the update of the EVM contract verification max width layout in the "Unreleased" section and reorganized existing entries.

Possibly related PRs

  • Feature/evm contract verfied abi #1206: The changes in this PR relate to the modification of the maxW property in the EvmContractVerifyFooter component, which also affects the layout of the EVM contract verification components.
  • feat: improve external verifier #1205: This PR is related to modifications in the EvmContractVerifyFooter component, specifically the introduction of the actionLabel prop, which is referenced in updates to the EvmContractVerifyBody component.
  • feat: validate evm verify form options #1225: This PR involves changes to the maxW property of the Grid component in the EvmContractVerifyBody, paralleling the updates to the layout properties in this PR.

Suggested reviewers

  • evilpeach
  • songwongtp

Poem

I'm a hopping rabbit full of cheer,
Celebrating new layouts that now appear.
Sticky footers and grids so neat,
Each change makes our UI complete.
With carrots 🥕 and a joyful beat,
Code and design now perfectly meet!
Hop on for more changes, oh so sweet!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d89ff4f and e89d028.

📒 Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (javascript)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/lib/pages/evm-contract-verify/components/EvmContractVerifyFooter.tsx (1)

25-46: Consider adding responsive design for better mobile experience.

The grid layout and styling look good, providing a balanced layout with appropriate spacing. However, consider making the grid layout responsive for better mobile experience.

Consider updating the grid template columns to be responsive:

-        gridTemplateColumns: "6fr 4fr",
+        gridTemplateColumns: { base: "1fr", md: "6fr 4fr" },
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ba6e1f and d89ff4f.

📒 Files selected for processing (2)
  • src/lib/pages/evm-contract-verify/components/EvmContractVerifyFooter.tsx (2 hunks)
  • src/lib/pages/evm-contract-verify/index.tsx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/lib/pages/evm-contract-verify/index.tsx
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
src/lib/pages/evm-contract-verify/components/EvmContractVerifyFooter.tsx (2)

1-1: LGTM!

The Box import from @chakra-ui/react is correctly added and necessary for the new wrapper component.


17-24: LGTM! Well-structured sticky footer implementation.

The Box wrapper provides a clean sticky footer implementation with appropriate visual separation through borders and padding. The z-index ensures proper layering.

@evilpeach evilpeach merged commit 1ac1732 into develop Feb 11, 2025
13 checks passed
@evilpeach evilpeach deleted the feature/update-verify-contract-layout branch February 11, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants