first #240
Draft
first #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soldni
reviewed
Feb 14, 2025
There was a problem hiding this comment.
mmmh this is ticky, would be nice to merge changes in soldni/backoff branch before touching linearizers
python/dolma/warc/processor.py
Outdated
| @@ -192,12 +194,15 @@ def process_single( | |||
| continue | |||
|
|
|||
| # extract text | |||
| doc.text = linearizer.linearize(content=decoded_content) | |||
| if skip_linearization: | |||
There was a problem hiding this comment.
can we have a no-op linearizer instead of a boolean flag?
python/dolma/cli/tagger.py
Outdated
| @@ -91,6 +91,10 @@ class TaggerConfig: | |||
| default=False, | |||
| help="If true, only print the configuration and exit without running the taggers.", | |||
| ) | |||
| document_dir: Optional[str] = field( | |||
There was a problem hiding this comment.
should we parametrize attributes too?
There was a problem hiding this comment.
We could for the sake of symmetry but it has little utility that I can see
All good, I wasn't planning on pushing this yet, mostly wanted to validate the tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.