-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Remove obsolete rm since we upgraded to Pytorch 0.2. #101
Conversation
@joelgrus are you able to give me instructions on how to reproduce the |
I'm able to build a Docker image and pass all tests with this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have much context on why/if this is fixed by upgrading, but if they build, I guess they build. LGTM.
it's there because I ran into this problem: hughperkins/pytorch#28 but if it works in the new version, it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I originally added that in because my docker builds were failing without it, which is what led me to the issue. |
Huh, that seems surprising as it's near the end of the Dockerfile. In any case, we're up and running again now that this is merged. https://cloud.docker.com/swarm/allennlp/repository/docker/allennlp/allennlp-gpu/tags |
No description provided.