lib: improve help information for api parameters #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #909 +/- ##
==========================================
- Coverage 82.66% 82.55% -0.12%
==========================================
Files 47 47
Lines 3860 3869 +9
==========================================
+ Hits 3191 3194 +3
- Misses 539 544 +5
- Partials 130 131 +1 ☔ View full report in Codecov by Sentry. |
yndu13
reviewed
Dec 27, 2023
| @@ -81,6 +115,9 @@ func GetProductName(language, code string) (name string, err error) { | |||
|
|
|||
| products := new(ProductSet) | |||
| err = json.Unmarshal(content, &products) | |||
| if err != nil { | |||
| return | |||
|
|
||
| func TestGetAPIDetail(t *testing.T) { | ||
| api, err := GetAPIDetail("en", "ecs", "DescribeRegions") | ||
| assert.Nil(t, err) |
yndu13
approved these changes
Dec 29, 2023
JacksonTian
force-pushed
the
api_help
branch
from
82150f1 to
0db0e7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.