-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/feedback #37
Merged
Merged
Feat/feedback #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emotion의 JSX pragma를 babel preset 형태로 변환하기 위해서 craco를 도입했습니다.
문제 없이 동작하는 모습 확인 완료
플러그인 추가 및 no-unused-vars 옵션 적용
타입 선언 및 필요한 props 타입 한번에 가져오기
hooks에서 발생할 수 있는 다양한 타입 예외 상황에 대한 처리 완료 및 any 제거
@를 앞에 붙이는 형태로 설정
이벤트에 필요한 React를 useTimer에서 import 그 외 emotion에서 사용하는 props에 대한 interface 추가
cursor: pointer
craco 설치, typescript-eslint 관련 요소들 추가, typescript 버전 4.6.2로 업그레이드
…to feat/feedback
움짤 추가
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSX pragma
제거padStart
를 통한 코드 리팩토링eslint
,prettier
적용 및@typescript-eslint
적용