Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass on maxNestingDepth to GenerateMappings #186

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

skolmer
Copy link
Contributor

@skolmer skolmer commented Jul 16, 2024

Description

This PR fixes an issue where the maxNestingDepth constructor param of GridifyMapper is not being passed on to the GenerateMappings function

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copy link

what-the-diff bot commented Jul 16, 2024

PR Summary

  • Updates to GenerateMappings method
    The method GenerateMappings in the GridifyMapper class has now been updated to accept a new parameter named maxNestingDepth. This parameter is used to specify how deep the mappings should be generated. This update allows us to control the depth of the mappings created, providing a more flexible and efficient workflow when handling extensive and complex data structures. This should help in improving performance and maintaining clarity in our mapping functionality.

Copy link
Owner

@alirezanet alirezanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! thank you 💐

@alirezanet alirezanet merged commit f9dff83 into alirezanet:master Jul 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants