Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert formatting into the lint step #16

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

styler3
Copy link
Contributor

@styler3 styler3 commented Nov 19, 2024

No description provided.

The prettier config doesn't actually do anything. It just removes some
rules from the default config that aren't compatible with prettier. To
get Prettier to actually work through ESLint, we need the plugin.
The format checks are handled through ESLint. Now that ESLint is fixed
up to be functioning properly, there is no more need for separate format
scripts.
@styler3 styler3 requested review from a user and kai-nguyen-aligent November 19, 2024 02:59
@styler3 styler3 requested a review from a team as a code owner November 19, 2024 02:59
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me!

Copy link
Contributor

@kai-nguyen-aligent kai-nguyen-aligent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a small question around removing part of the pipeline

.github/workflows/pull-request.yml Show resolved Hide resolved
@styler3 styler3 merged commit 9e7eb91 into main Nov 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants