Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store profile to configmap or home dir and merge profiles to select when upgrade and uninstall #649

Merged
merged 7 commits into from
Dec 5, 2023

Conversation

2456868764
Copy link
Collaborator

@2456868764 2456868764 commented Nov 21, 2023

Ⅰ. Describe what this PR did

store profile to configmap or home dir and merge profiles to select when upgrade and uninstall

  1. upgrade from .hgctl/profiles/install.yaml
截屏2023-11-22 14 21 41
  1. after upgrading from .hgctl/profiles/install.yaml, store profile to configmap
截屏2023-11-22 14 53 11
  1. after installing higress in local docker envoriments
截屏2023-11-22 14 53 32 截屏2023-11-22 14 55 15
  1. after installing higress to new namespace: higress-system2 and merging profiles from .hgctl/profiles and configmap from multi namespaces
截屏2023-11-22 14 58 03
  1. uninstall
截屏2023-11-22 15 02 30

Ⅱ. Does this pull request fix one issue?

#570 #641

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2023

Codecov Report

Merging #649 (f037b24) into main (57b8cb1) will increase coverage by 0.24%.
Report is 12 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #649      +/-   ##
==========================================
+ Coverage   35.41%   35.66%   +0.24%     
==========================================
  Files          71       73       +2     
  Lines       10244    10439     +195     
==========================================
+ Hits         3628     3723      +95     
- Misses       6331     6430      +99     
- Partials      285      286       +1     
Files Coverage Δ
pkg/cmd/hgctl/install.go 0.00% <0.00%> (ø)
pkg/cmd/hgctl/uninstall.go 0.00% <0.00%> (ø)
pkg/cmd/hgctl/upgrade.go 0.00% <0.00%> (ø)

... and 11 files with indirect coverage changes

@2456868764 2456868764 changed the title feat: store profile to configmap or home dir and merge profiles to upgrade and uninstall feat: store profile to configmap or home dir and merge profiles to select when upgrade and uninstall Nov 21, 2023
@johnlanni
Copy link
Collaborator

@2456868764 I think we should inform users more clearly that the profile has been converted to k8s configmap and prompt them to provide the kubectl edit cm command for editing.

@2456868764
Copy link
Collaborator Author

2456868764 commented Dec 4, 2023

@2456868764 I think we should inform users more clearly that the profile has been converted to k8s configmap and prompt them to provide the kubectl edit cm command for editing.

after install or upgrade , it will prompt " kubectl edit configmap higress-install-profile -n higress-system
" which is captured as bellow:
截屏2023-12-04 12 53 51

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit bd4109e into alibaba:main Dec 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants