-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: store profile to configmap or home dir and merge profiles to select when upgrade and uninstall #649
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #649 +/- ##
==========================================
+ Coverage 35.41% 35.66% +0.24%
==========================================
Files 71 73 +2
Lines 10244 10439 +195
==========================================
+ Hits 3628 3723 +95
- Misses 6331 6430 +99
- Partials 285 286 +1
|
@2456868764 I think we should inform users more clearly that the profile has been converted to k8s configmap and prompt them to provide the kubectl edit cm command for editing. |
after install or upgrade , it will prompt " kubectl edit configmap higress-install-profile -n higress-system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
store profile to configmap or home dir and merge profiles to select when upgrade and uninstall
Ⅱ. Does this pull request fix one issue?
#570 #641
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews