feat: add nginx static-files wasm plugin #1643
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haifzhu
requested review from
Xunzhuo,
2456868764,
CH3CHO,
johnlanni and
rinfx
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1643 +/- ##
==========================================
+ Coverage 35.91% 43.52% +7.61%
==========================================
Files 69 76 +7
Lines 11576 12325 +749
==========================================
+ Hits 4157 5364 +1207
+ Misses 7104 6626 -478
- Partials 315 335 +20 |
johnlanni
requested changes
Jan 6, 2025
| | 名称 | 数据类型 | 填写要求 | 默认值 | 描述 | | ||
| | -------- | -------- | -------- | -------- | -------- | | ||
| | `root` | string | 非必填 | - | root路径 | | ||
| | `alias_path` | string | 非必填 | - | alias待替换的路径 | |
There was a problem hiding this comment.
alias path 用户不容易理解，还是用 location 来配置路径吧
johnlanni
requested changes
Jan 6, 2025
| - `try paths`: 请求基于不同的路径进行重试，直到请求到正确返回的请求。 | ||
|
|
||
| # 配置字段 | ||
|
|
There was a problem hiding this comment.
我倾向于只配置一条路由转发给oss服务，然后这个路由上配置这个插件，通过 location 数组，指定好每个兼容nginx location的静态文件转发规则
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
支持nginx static files的功能，支持指令:
Ⅱ. Does this pull request fix one issue?
fix #840
Ⅲ. Why don't you add test cases (unit test/integration test)?
test cases be added in codes.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews