Merge pull request #265 from alibaba/fix-webpack-public-path

fix(@dawnjs/dn-middleware-webpack): set publicPath to "/" in development mode
alibaba · Jun 22, 2021 · 8db9962 · 8db9962
2 parents 9cb3f07 + e46d6e0
commit 8db9962
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/packages/middleware-webpack/src/config/configModule.ts b/packages/middleware-webpack/src/config/configModule.ts
@@ -394,7 +394,7 @@ export default async (config: Config, options: INormalizedOpts) => {
             if (typeof customOptions === "function") {
               customOptions = customOptions(loaderContext);
             }
-            return { fiber: Fiber, ...customOptions };
+            return { fiber: Fiber, quietDeps: true, ...customOptions };
           },
         },
       },

diff --git a/packages/middleware-webpack/src/config/configOutput.ts b/packages/middleware-webpack/src/config/configOutput.ts
@@ -7,8 +7,7 @@ export default async (config: Config, options: INormalizedOpts) => {
     .filename(path.join(options.folders.script, "[name].js"))
     .chunkFilename(path.join(options.folders.script, "[name].[chunkhash:8].chunk.js"))
     .set("assetModuleFilename", path.join(options.folders.media, "[name].[contenthash:8][ext]")) // TODO: replace after webpack-chain support webpack5
-    .publicPath(options.publicPath)
-    .globalObject("this")
+    .publicPath(options.publicPath ?? (options.env === "development" ? "/" : undefined))
     .merge(options.output)
     .path(path.resolve(options.cwd, options.output.path));
 };
diff --git a/packages/middleware-webpack/src/opts.ts b/packages/middleware-webpack/src/opts.ts
@@ -74,7 +74,7 @@ export const normalizeOpts = (opts: Partial<IOpts>, ctx: Context): INormalizedOp
       ...opts.folders,
     },
     babel: {
-      jsxRuntime: opts.jsxRuntime,
+      jsxRuntime: opts.jsxRuntime ?? true,
       runtimeHelpers: true,
       corejs: 3,
       ...opts.babel,