Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add assert and [[nodiscard]] for spinlock #413

Merged
merged 3 commits into from
Jan 21, 2025
Merged

add assert and [[nodiscard]] for spinlock #413

merged 3 commits into from
Jan 21, 2025

Conversation

poor-circle
Copy link
Contributor

Why

  1. Close async_simple::coro::Mutex should contain <cassert> head file #391
  2. We found some mistake use of spinlock in user issue

What is changing

  1. add cassert header for Mutex.h
  2. add nodiscard attribute for SpinLock::coScopedLock()
  3. add assert for SpinLock::unlock()

Example

@ChuanqiXu9
Copy link
Collaborator

Please take a look at the cmake failure

@ChuanqiXu9 ChuanqiXu9 merged commit 05f432e into alibaba:main Jan 21, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuanqiXu9 ChuanqiXu9 ChuanqiXu9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

async_simple::coro::Mutex should contain <cassert> head file
2 participants
@poor-circle @ChuanqiXu9