refactor syncAwait without executor (draft version) #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuanqiXu9
reviewed
Dec 31, 2024
Comment on lines
+63
to
+64
| * 解决办法：1. | ||
| * cv+mutex+quit_flag，这种情况对性能有损伤（不过现代架构下锁争抢是性能衰退的主要原因，无冲突的加解锁可以接受）。 |
There was a problem hiding this comment.
我个人意见一直是不把不绑定调度器的情况看作主要使用方式的而且 syncAwait 按设计也是只应该在测试中使用。所以这种情况下损失性能就损伤了吧。
当然我觉得直接把这个函数的实现里写个 assert 也是可以的
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a test for CI
Why
#404
What is changing
Example