add assert and [[nodiscard]] for spinlock

alibaba · Jan 20, 2025 · 929d709 · 929d709
1 parent abaffa9
commit 929d709
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/async_simple/coro/Mutex.h b/async_simple/coro/Mutex.h
@@ -25,6 +25,7 @@
 
 #ifndef ASYNC_SIMPLE_USE_MODULES
 #include <atomic>
+#include <cassert>
 #include <mutex>
 #include "async_simple/experimental/coroutine.h"
 

diff --git a/async_simple/coro/SpinLock.h b/async_simple/coro/SpinLock.h
@@ -16,7 +16,9 @@
 #ifndef ASYNC_SIMPLE_CORO_SPIN_LOCK_H
 #define ASYNC_SIMPLE_CORO_SPIN_LOCK_H
 
+#include <atomic>
 #ifndef ASYNC_SIMPLE_USE_MODULES
+#include <cassert>
 #include <mutex>
 #include <thread>
 #include "async_simple/coro/Lazy.h"
@@ -60,9 +62,12 @@ class SpinLock {
         }
     }
 
-    void unlock() noexcept { _locked.store(false, std::memory_order_release); }
+    void unlock() noexcept {
+        assert(_locked.load(std::memory_order_acquire) == true);
+        _locked.store(false, std::memory_order_release);
+    }
 
-    Lazy<std::unique_lock<SpinLock>> coScopedLock() {
+    [[nodiscard]] Lazy<std::unique_lock<SpinLock>> coScopedLock() {
         co_await coLock();
         co_return std::unique_lock<SpinLock>{*this, std::adopt_lock};
     }