Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: overlay events #139

Draft
wants to merge 2 commits into
base: refactor/modals
Choose a base branch
from
Draft

Conversation

PhearZero
Copy link
Member

@PhearZero PhearZero commented Jan 27, 2025

ℹ Overview

Split this into two PRs due to the size of the changes.

  • refactors ModalEvent to KeySelectedEvent to avoid confusion
  • removes Type from ModalEvent in favor of the more discrete ShowModal(ModalType)
  • refactors modal to overlay
  • allows event propagation to the child modals

Related Issues

@PhearZero PhearZero self-assigned this Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 74.13793% with 45 lines in your changes missing coverage. Please review.

Project coverage is 43.29%. Comparing base (6b04f44) to head (c50f7fc).

Files with missing lines Patch % Lines
ui/viewport.go 57.14% 19 Missing and 2 partials ⚠️
ui/overlay/controller.go 76.74% 9 Missing and 1 partial ⚠️
ui/modals/transaction/controller.go 25.00% 6 Missing ⚠️
ui/modals/transaction/view.go 0.00% 4 Missing ⚠️
ui/app/accounts.go 40.00% 2 Missing and 1 partial ⚠️
cmd/root.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           refactor/modals     #139       +/-   ##
====================================================
+ Coverage            33.14%   43.29%   +10.14%     
====================================================
  Files                   76       77        +1     
  Lines                 6393     6329       -64     
====================================================
+ Hits                  2119     2740      +621     
+ Misses                4160     3358      -802     
- Partials               114      231      +117     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PhearZero PhearZero linked an issue Jan 28, 2025 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

♻️ Refactor modal components
1 participant