fix: deterministic state while detecting corrupt keys #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.2.0 #133 +/- ##
===========================================
- Coverage 44.40% 32.78% -11.63%
===========================================
Files 76 76
Lines 6308 6333 +25
===========================================
- Hits 2801 2076 -725
- Misses 3277 4146 +869
+ Partials 230 111 -119 ☔ View full report in Codecov by Sentry. |
PhearZero
force-pushed
the
fix/finding
branch
from
4b8229d to
d87ce8c
Compare
Deploying nodekit-run with
|
| Latest commit: |
d87ce8c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://23857438.nodekit-run.pages.dev |
| Branch Preview URL: | https://fix-finding.nodekit-run.pages.dev |
tasosbit
reviewed
Jan 23, 2025
Comment on lines
+87
to
+91
| if ok { | ||
| if acct.Participation != nil && acct.Status == "Offline" { | ||
| m.SetSuspended(true) | ||
| } | ||
| } |
There was a problem hiding this comment.
Do we need to else setsuspended false here? otherwise how is the suspended flag cleared after the user has re-reged online?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ Overview
📝 Related Issues
✅ Acceptance: