Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: toggle between QRCode and deep-link #130

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

PhearZero
Copy link
Member

ℹ Overview

  • toggles between QR and Lora Link

Copy link

cloudflare-workers-and-pages bot commented Jan 22, 2025

Deploying nodekit-run with  Cloudflare Pages  Cloudflare Pages

Latest commit: 10551b1
Status: ✅  Deploy successful!
Preview URL: https://b6e2c449.nodekit-run.pages.dev
Branch Preview URL: https://feat-separate-views-in-txn-m.nodekit-run.pages.dev

View logs

@PhearZero PhearZero marked this pull request as ready for review January 22, 2025 18:43
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 36.66667% with 38 lines in your changes missing coverage. Please review.

Project coverage is 33.18%. Comparing base (a3421bc) to head (10551b1).
Report is 11 commits behind head on v1.2.0.

Files with missing lines Patch % Lines
ui/modals/transaction/view.go 0.00% 31 Missing ⚠️
ui/modals/transaction/controller.go 65.00% 7 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (a3421bc) and HEAD (10551b1). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (a3421bc) HEAD (10551b1)
3 1
Additional details and impacted files
@@             Coverage Diff             @@
##           v1.2.0     #130       +/-   ##
===========================================
- Coverage   46.27%   33.18%   -13.10%     
===========================================
  Files          76       76               
  Lines        6217     6235       +18     
===========================================
- Hits         2877     2069      -808     
- Misses       3116     4061      +945     
+ Partials      224      105      -119     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PhearZero PhearZero merged commit 90b769d into v1.2.0 Jan 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants