Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/accounts page add incentive eligibility, fix: non-resident keys in txn modal #124

Merged
merged 7 commits into from
Jan 22, 2025

Conversation

tasosbit
Copy link
Contributor

ℹ Overview

Changed accounts table view

  • Removed # keys column
  • Added Rewards column: ELIGIBLE | PAUSED | INELIGIBLE | ""
    • PAUSED refers to balance check fail
  • Changed Status values: IDLE | PARTICIPATING

Fixed support for non-resident key error in transaction modal:

  • counts matching fields in transaction controller. 6/6 match is good, 4/6 and 5/6 are detected as non resident keys and warns user.

✅ Acceptance:

  • Pre-commit checks pass

@tasosbit tasosbit changed the base branch from main to v1.2.0 January 21, 2025 17:26
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 14.60674% with 76 lines in your changes missing coverage. Please review.

Please upload report for BASE (v1.2.0@443b633). Learn more about missing BASE report.

Files with missing lines Patch % Lines
ui/modal/controller.go 0.00% 53 Missing ⚠️
ui/pages/accounts/model.go 48.00% 8 Missing and 5 partials ⚠️
ui/modal/model.go 0.00% 7 Missing ⚠️
ui/modals/info/info.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             v1.2.0     #124   +/-   ##
=========================================
  Coverage          ?   34.22%           
=========================================
  Files             ?       76           
  Lines             ?     6290           
  Branches          ?        0           
=========================================
  Hits              ?     2153           
  Misses            ?     4024           
  Partials          ?      113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cloudflare-workers-and-pages bot commented Jan 21, 2025

Deploying nodekit-run with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2d00496
Status: ✅  Deploy successful!
Preview URL: https://abb094bb.nodekit-run.pages.dev
Branch Preview URL: https://feat-accounts-page-add-incen.nodekit-run.pages.dev

View logs

@tasosbit tasosbit force-pushed the feat/accounts-page-add-incentive-eligibility branch from 717fc8f to 184d383 Compare January 22, 2025 10:53
@PhearZero PhearZero added the task label Jan 22, 2025
@PhearZero PhearZero self-requested a review January 22, 2025 14:07
ui/modal/controller.go Show resolved Hide resolved
ui/modal/controller.go Show resolved Hide resolved
@PhearZero PhearZero merged commit c2a483f into v1.2.0 Jan 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants