Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add disk space information to debug command #123

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

tasosbit
Copy link
Contributor

@tasosbit tasosbit commented Jan 21, 2025

ℹ Overview

  • Added the free space of the data dir in bytes and MB to the debug command. Available disk space is relevant in a lot of scenarios, including debugging "fast catchup takes too long to complete".
  • Added nodekti version to the debug command

✅ Acceptance:

  • Pre-commit checks pass

cmd/debug.go Show resolved Hide resolved
@tasosbit
Copy link
Contributor Author

not tested on mac yet

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (v1.2.0@d8b44a6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
cmd/debug.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             v1.2.0     #123   +/-   ##
=========================================
  Coverage          ?   47.05%           
=========================================
  Files             ?       76           
  Lines             ?     6116           
  Branches          ?        0           
=========================================
  Hits              ?     2878           
  Misses            ?     3015           
  Partials          ?      223           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cloudflare-workers-and-pages bot commented Jan 21, 2025

Deploying nodekit-run with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0fb02c2
Status: ✅  Deploy successful!
Preview URL: https://9d73fc8e.nodekit-run.pages.dev
Branch Preview URL: https://feat-debug-show-disk-stats.nodekit-run.pages.dev

View logs

@tasosbit tasosbit force-pushed the feat/debug-show-disk-stats branch from 8c7fdd9 to ee0d5a3 Compare January 21, 2025 13:00
@tasosbit tasosbit requested a review from PhearZero January 21, 2025 16:27
@PhearZero PhearZero changed the base branch from main to v1.2.0 January 21, 2025 20:10
Copy link
Member

@PhearZero PhearZero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks out on mac

Screenshot from 2025-01-21 15-24-17

@PhearZero PhearZero merged commit 2076624 into v1.2.0 Jan 21, 2025
6 checks passed
tasosbit pushed a commit that referenced this pull request Jan 22, 2025
…stats

feat: add disk space information to debug command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants