Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: remove unused EnableOnlineAccountCatchpoints consensus flag, rename EnableAccountDataResourceSeparation #6242

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cce
Copy link
Contributor

@cce cce commented Feb 4, 2025

Summary

Cleaning up two consensus flags that were used to control behavior related to catchpoint versioning:

  • EnableOnlineAccountCatchpoints is not checked or referenced in the code anywhere, and may now be removed.
  • EnableAccountDataResourceSeparation has a misleading name and is renamed here to reflect what it actually does.

Test Plan

No logical code changes, just renaming; existing tests should pass.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.76%. Comparing base (01186d0) to head (6f0dc72).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6242   +/-   ##
=======================================
  Coverage   51.76%   51.76%           
=======================================
  Files         644      644           
  Lines       86521    86520    -1     
=======================================
+ Hits        44786    44791    +5     
+ Misses      38870    38863    -7     
- Partials     2865     2866    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cce added a commit to algorand/go-algorand-sdk that referenced this pull request Feb 4, 2025
cce added a commit to algorand/go-algorand-sdk that referenced this pull request Feb 4, 2025
@cce
Copy link
Contributor Author

cce commented Feb 4, 2025

Companion PR: algorand/go-algorand-sdk#679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants