Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Gary <[email protected]>
  • Loading branch information
algorandskiy and gmalouf authored Dec 6, 2023
1 parent 6e2a2fe commit 368ee34
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
4 changes: 2 additions & 2 deletions network/requestTracker.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,14 @@ const (
type TrackerRequest struct {
created time.Time
// remoteHost is IP address of the remote host and it is equal to either
// a host part of the remoteAddr or to the value of X-Forwarded-For header.
// a host part of the remoteAddr or to the value of X-Forwarded-For header (UseXForwardedForAddressField config value).
remoteHost string
// remotePort is the port of the remote peer as reported by the connection or
// by the standard http.Request.RemoteAddr field.
remotePort string
// remoteAddr is IP:Port of the remote host retrieved from the connection
// or from the standard http.Request.RemoteAddr field.
// This field the real address of the remote incomming connection.
// This field the real address of the remote incoming connection.
remoteAddr string
// otherPublicAddr is the public address of the other node, as reported by the other node
// via the X-Algorand-Location header.
Expand Down
1 change: 0 additions & 1 deletion network/wsNetwork_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1430,7 +1430,6 @@ func TestPeeringWithIdentityChallenge(t *testing.T) {
netA.wg.Add(1)
netA.tryConnect(addrB, gossipC)
// let the tryConnect go forward
time.Sleep(250 * time.Millisecond)
assert.Eventually(t, func() bool {
return len(netA.GetPeers(PeersConnectedOut)) == 2
}, time.Second, 50*time.Millisecond)
Expand Down

0 comments on commit 368ee34

Please sign in to comment.