Fixed an issue that prevented hyperparameter optimisation of `xgboost…

…` models for survival tasks.
alexzwanenburg · May 22, 2024 · d484a1e · d484a1e
1 parent d3eb80d
commit d484a1e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -4,6 +4,8 @@
 
 - Adapted tests to work when packages are missing.
 
+- Fixed an issue that prevented hyperparameter optimisation of `xgboost` models for survival tasks.
+
 # Version 1.4.7 (Uncertain Unicorn)
 
 ## Bug fixes

diff --git a/R/LearnerS4XGBoost.R b/R/LearnerS4XGBoost.R
@@ -365,9 +365,7 @@ setMethod("get_prediction_type", signature(object="familiarXGBoost"),
 
             # The prediction type is a bit more complicated for xgboost methods.
             if(type == "default"){
-              if(as.character(object@hyperparameters$learn_objective %in% c("cox"))){
-                return("hazard_ratio")
-              }
+              return("hazard_ratio")
 
             } else if(type == "survival_probability"){
               return("survival_probability")